-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not list tables required by extensions #5687
Conversation
b14eff1
to
63b0b4c
Compare
Hi @morozov I am running into an issue with the
In our system, the
Query 1:
Results of Query 1:
Results of Query 2:
It seems like my Thanks for your time. |
@allenisalai could you file a new issue, please? I have very little experience with PostgreSQL as well, so it's quite likely that I made a mistake. You can also file a pull request with the changes that work for you. You can omit a test for now since the issue may be inconsistently reproducible. I'll try to validate the patch using the documentation. |
Done. #5781. I'll work on a PR on my end in the next couple days. Thanks. |
Fixes #5668.
The implementation prior to 3.4.0 did not list the
spatial_ref_sys
table due to this hack:dbal/src/Platforms/PostgreSQLPlatform.php
Line 279 in f873a82
As #5668 (comment) shows, this hack is insufficient as it doesn't cover all tables required by any possible extension.
The patch fixes the query in
selectTableColumns()
but doesn't fixgetListTablesSQL()
since it's not a regression. We can fix it in a separate patch.In order to add a new
LEFT JOIN
, the query needs to be reworked from using implicit joins (SELECT * FROM a, b, c
) to using explicit joins.We should consider adding a build against something like postgis/postgis on CI in order to make this change integration-tested.